[PATCH] D74904: [CallSiteInfo] Handle bundles when updating call site info

Djordje Todorovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 26 02:22:55 PST 2020


djtodoro marked an inline comment as done.
djtodoro added inline comments.


================
Comment at: llvm/lib/CodeGen/MachineFunction.cpp:886
+  if (MI->isBundle()) {
+    auto BundleIt = MI->getIterator();
+    do {
----------------
dstenb wrote:
> As the {erase,copy,move} functions seems to handle bundles in the same way, perhaps it is worth breaking this out to a common helper that either returns MI if it's not a bundle, or finds the call instruction in the bundle?
Makes sense, thanks.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74904/new/

https://reviews.llvm.org/D74904





More information about the llvm-commits mailing list