[PATCH] D73887: [DebugInfo] Do not truncate 64-bit values when dumping CIEs and FDEs.

Wed Feb 26 01:59:56 PST 2020

ikudrin marked 8 inline comments as done.
ikudrin added inline comments.

================
Comment at: llvm/unittests/DebugInfo/DWARF/DWARFDebugFrameTest.cpp:21
+  dwarf::CIE TestCIE(
+      /* IsDWARF64 = */ true,
+      /* Offset = */ 0x1111abcdabcdULL,
----------------
jhenderson wrote:
> ikudrin wrote:
> > jhenderson wrote:
> > > clang-format-recognised style is `/*IsDWARF64=*/true`.
> > > 
> > > Same principle applies throughout.
> > A side note. It looks like `clang-format` recognizes both styles, and both are used in the LLVM codebase, but the condensed variant is way more widespread and also is mentioned in the LLVM Coding Standards (not as a requirement, just as an example).
> When you say "recognises" I think what happens is that it treats the old style as a normal inline comment, so applies the normal comment formatting rules. That is based purely on observation though, so I could be completely wrong!
Well, maybe it does not need to recognize them in a special way if the result of the formatting is the same as expected. Anyway, I agree that it is better to stick with a more widespread style despite my personal taste.

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73887/new/

https://reviews.llvm.org/D73887