[PATCH] D73887: [DebugInfo] Do not truncate 64-bit values when dumping CIEs and FDEs.
Igor Kudrin via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 26 01:09:33 PST 2020
ikudrin marked an inline comment as done.
ikudrin added inline comments.
================
Comment at: llvm/unittests/DebugInfo/DWARF/DWARFDebugFrameTest.cpp:21
+ dwarf::CIE TestCIE(
+ /* IsDWARF64 = */ true,
+ /* Offset = */ 0x1111abcdabcdULL,
----------------
jhenderson wrote:
> clang-format-recognised style is `/*IsDWARF64=*/true`.
>
> Same principle applies throughout.
A side note. It looks like `clang-format` recognizes both styles, and both are used in the LLVM codebase, but the condensed variant is way more widespread and also is mentioned in the LLVM Coding Standards (not as a requirement, just as an example).
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D73887/new/
https://reviews.llvm.org/D73887
More information about the llvm-commits
mailing list