[PATCH] D74605: [ARM][RDA] add getUniqueReachingMIDef

[Sjoerd Meijer via Phabricator via llvm-commits]

SjoerdMeijer added inline comments.


================
Comment at: llvm/include/llvm/CodeGen/ReachingDefAnalysis.h:155
 
+  /// Search MBB for a definition of PhysReg and insert it into Incoming. If no
+  /// definition is found, recursively search the predecessor blocks for them.
----------------
Incoming -> Defs?


================
Comment at: llvm/include/llvm/CodeGen/ReachingDefAnalysis.h:222
+  /// nullptr if the id does not refer to the block.
+  MachineInstr *getInstFromId(MachineBasicBlock *MBB, int InstId) const;
+
----------------
This function already exists. Why this change? 


================
Comment at: llvm/lib/CodeGen/ReachingDefAnalysis.cpp:337
+  MachineInstr *LocalDef = getReachingLocalMIDef(MI, PhysReg);
+  if (InstIds.lookup(LocalDef) < InstIds.lookup(MI))
+    return LocalDef;
----------------
nit: use shorter notation?

   if (InstIds[LocalDef] < InstIds[MI])


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74605/new/

https://reviews.llvm.org/D74605