[PATCH] D75015: [ARM] Rewrite ARMAttributeParser

[Fangrui Song via Phabricator via llvm-commits]

MaskRay marked 2 inline comments as done.
MaskRay added inline comments.


================
Comment at: llvm/lib/Support/ARMAttributeParser.cpp:501
+    } else if (Error e = parseAttributeList(size))
+      return e;
   }
----------------
grimar wrote:
> Seems it can be:
> 
> ```
> if (sw) {
>   DictScope scope(*sw, scopeName);
>   if (!indicies.empty())
>     sw->printList(indexName, indicies);
> } 
> 
> if (Error e = parseAttributeList(size))
>   return e;
> ```
It can't.

DictScope changes the indentation level. `parseAttributeList` must be called with `DictScope` in the scope.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75015/new/

https://reviews.llvm.org/D75015