[PATCH] D75095: [MC][ARM] Don't create multiple .ARM.exidx associated to one .text

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 25 18:19:26 PST 2020


This revision was automatically updated to reflect the committed changes.
Closed by commit rGd0c4277d3886: [MC][ARM] Don't create multiple .ARM.exidx associated to one .text (authored by MaskRay).

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75095/new/

https://reviews.llvm.org/D75095

Files:
  llvm/lib/MC/MCContext.cpp
  llvm/lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp


Index: llvm/lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp
===================================================================
--- llvm/lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp
+++ llvm/lib/Target/ARM/MCTargetDesc/ARMELFStreamer.cpp
@@ -1201,7 +1201,7 @@
     Flags |= ELF::SHF_GROUP;
   MCSectionELF *EHSection = getContext().getELFSection(
       EHSecName, Type, Flags, 0, Group, FnSection.getUniqueID(),
-      static_cast<const MCSymbolELF *>(&Fn));
+      static_cast<const MCSymbolELF *>(FnSection.getBeginSymbol()));
 
   assert(EHSection && "Failed to get the required EH section");
 
Index: llvm/lib/MC/MCContext.cpp
===================================================================
--- llvm/lib/MC/MCContext.cpp
+++ llvm/lib/MC/MCContext.cpp
@@ -405,6 +405,7 @@
   StringRef Group = "";
   if (GroupSym)
     Group = GroupSym->getName();
+  assert(!(LinkedToSym && LinkedToSym->getName().empty()));
   // Do the lookup, if we have a hit, return it.
   auto IterBool = ELFUniquingMap.insert(std::make_pair(
       ELFSectionKey{Section.str(), Group,


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D75095.246615.patch
Type: text/x-patch
Size: 1068 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200226/7d6f018d/attachment.bin>


More information about the llvm-commits mailing list