[PATCH] D71845: [AIX][XCOFF] Fixed a bug of XCOFFObjectWriter.cpp and add test for raw text section content and test section header
Digger via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 25 15:59:37 PST 2020
DiggerLin marked 2 inline comments as done.
DiggerLin added inline comments.
================
Comment at: llvm/test/CodeGen/PowerPC/aix-return55.ll:20
+;CHECKOBJ-NEXT: 00000008 .rodata.str1.1:
+;CHECKOBJ-NEXT: 8: 68 65 6c 6c xori 5, 3, 27756
+;CHECKOBJ-NEXT: c: 6f 20 77 6f xoris 0, 25, 30575
----------------
daltenty wrote:
> nit: Remove the disassembly column from the check lines for this and `.data`, since we are actually only interested in the raw data
if there is "Disassembly of section .data", it is more clear that the following raw data is data section.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D71845/new/
https://reviews.llvm.org/D71845
More information about the llvm-commits
mailing list