[PATCH] D75132: [SelectionDAG][PowerPC][AArch64][X86][ARM] Add chain input and output the ISD::FLT_ROUNDS_

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 25 15:50:35 PST 2020


efriedma accepted this revision.
efriedma added a comment.
This revision is now accepted and ready to land.

LGTM, assuming you verified we have reasonable test coverage on the targets you modified.



================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:8310
+  SDValue Chain = Op.getOperand(0);
+  SDValue MFFS = DAG.getNode(PPCISD::MFFS, dl, {MVT::f64, MVT::Other}, Chain);
+  Chain = MFFS.getValue(1);
----------------
Changing "Glue" to "other" looked strange at first glance, but I guess this is the only place that uses this node.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75132/new/

https://reviews.llvm.org/D75132





More information about the llvm-commits mailing list