[PATCH] D75098: Add COPY_BR, a terminator form of the COPY instr

Tue Feb 25 15:08:18 PST 2020

void marked an inline comment as done.
void added a comment.

In D75098#1892171 <https://reviews.llvm.org/D75098#1892171>, @nickdesaulniers wrote:

> Also, if INLINEASM_BR is a terminator, but we want TCOPY to be a terminator, should this patch make INLINEASM_BR NOT a terminator? Or would that be a follow up patch after creating TCOPY?

`INLINEASM_BR` being a terminator makes a lot of things "just work" for the code generator. I'm not 100% convinced that it *should* be a terminator, but if we decided to make it a normal instruction, then I think we'd have to touch way too much code to make it worthwhile.

> Also, none of the tests have TCOPY (or w/e). I feel like any patch adding a new instructions at w/e level of IR should have some test that the instruction exists.

The tests are the current "asm goto with outputs" tests.

> Also, I don't quite follow what the changes to the tests are testing for with this change.

The test changes are testing that we can compile at `-O0`.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75098/new/

https://reviews.llvm.org/D75098