[PATCH] D74968: [XCOFF] Handle MCSA_LGlobal in emitSymbolAttribute

David Tenty via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 25 14:30:28 PST 2020


daltenty marked 3 inline comments as done.
daltenty added inline comments.


================
Comment at: llvm/lib/MC/MCXCOFFStreamer.cpp:13
 
+#include "llvm/MC/MCXCOFFStreamer.h"
 #include "llvm/BinaryFormat/XCOFF.h"
----------------
jasonliu wrote:
> Why do we move this "#include" here?
Per the style guide, a "Main Module Header" should come first in the include list. This is where clang-format will place it.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74968/new/

https://reviews.llvm.org/D74968





More information about the llvm-commits mailing list