[PATCH] D72360: [Test] Make llvm and lld tests pass when $USER matches `bar`
Fangrui Song via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 25 13:34:36 PST 2020
MaskRay added inline comments.
================
Comment at: lld/test/COFF/start-lib.ll:26
; TEST2-NOT: Name: foo
-; TEST2: bar
+; TEST2: {{[[:<:]]bar}}
; TEST2-NOT: Name: foo
----------------
bbaren wrote:
> rupprecht wrote:
> > I'm not sure what this is supposed to be. Can it just be `Name: bar`? Ditto for `TEST3-NOT` below
> `Name: bar` doesn’t work – the map file contains
>
> ```
> 00001010 00000000 0 bar
> ```
>
> However, @MaskRay’s suggestion below applies here as well. Changed to `{{ }}bar`.
Maybe it is clearer to match the full line.
================
Comment at: lld/test/ELF/lto/linker-script-symbols-assign.ll:6
; RUN: ld.lld %t.o -o %t2 --script %t.script -save-temps
-; RUN: llvm-readobj --symbols %t2.lto.o | FileCheck %s
+; RUN: llvm-nm %t2.lto.o | FileCheck --allow-empty %s
----------------
`| count 0`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D72360/new/
https://reviews.llvm.org/D72360
More information about the llvm-commits
mailing list