[PATCH] D75091: [X86MCTargetDesc.h] Speculative fix for macro collision with sys/param.h

[Vedant Kumar via Phabricator via llvm-commits]

vsk added a comment.

I thought this was enough to unblock the bot, but we're pulling in macros in other places as well:

  /Users/buildslave/jenkins/workspace/lldb-cmake/llvm-project/llvm/tools/llvm-ar/llvm-ar.cpp:177:29: error: expected identifier
  enum Format { Default, GNU, BSD, DARWIN, Unknown };
                              ^
  /Applications/Xcode.app/Contents/Developer/Platforms/MacOSX.platform/Developer/SDKs/MacOSX10.14.sdk/usr/include/sys/param.h:72:13: note: expanded from macro 'BSD'
  #define BSD     199506          /* System version (year & month). */
                  ^

I don't think it's acceptable to `#undef` our way out of this. Are the system/SDL headers incorrect, or is llvm's modulemap incorrect? Something else?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75091/new/

https://reviews.llvm.org/D75091