[PATCH] D70097: [SCEV] Add missing cache queries

Keno Fischer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 25 12:52:27 PST 2020


loladiro added inline comments.


================
Comment at: llvm/lib/Analysis/ScalarEvolution.cpp:2455
 
+  if (SCEV *S = std::get<0>(findExistingSCEVInCache(scAddExpr, Ops))) {
+    static_cast<SCEVAddExpr *>(S)->setNoWrapFlags(Flags);
----------------
I know we do this in a few other places, but why is this legal? Isn't it possible we're still using the old SCEV somewhere, but without the flags?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D70097/new/

https://reviews.llvm.org/D70097





More information about the llvm-commits mailing list