[PATCH] D73142: Heat Coloring for CFGPrinter and CallPrinter

[Kirill Naumov via Phabricator via llvm-commits]

knaumov updated this revision to Diff 246543.
knaumov added a comment.

- Removed flag that was targeting coloring BB based on their relative hotness across the module.

I have decided to do that for the following reasons:

1. The patch is self-contained without this feature. This feature can be added in a follow-up patch.
2. The feature itself is not as important and valuable as was first thought of.

My suggestions for implementing this feature:
Although we only have a relative frequency of BB with respect to the function, using the relative frequency of a function with respect to the module we can translate it to be relative to the module. We can do that using ProfileSummary to get the number of entries per a function.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73142/new/

https://reviews.llvm.org/D73142

Files:
  llvm/include/llvm/Analysis/CFGPrinter.h
  llvm/include/llvm/Analysis/HeatUtils.h
  llvm/lib/Analysis/CFGPrinter.cpp
  llvm/lib/Analysis/CMakeLists.txt
  llvm/lib/Analysis/CallPrinter.cpp
  llvm/lib/Analysis/DomPrinter.cpp
  llvm/lib/Analysis/HeatUtils.cpp
  llvm/lib/Analysis/RegionPrinter.cpp
  llvm/lib/Passes/PassRegistry.def
  llvm/lib/Transforms/Scalar/NewGVN.cpp
  llvm/test/Other/2007-06-05-PassID.ll
  llvm/test/Other/cfg-printer-branch-weights-percent.ll
  llvm/test/Other/cfg-printer-branch-weights.ll
  polly/lib/Analysis/ScopGraphPrinter.cpp
  polly/lib/Support/RegisterPasses.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D73142.246543.patch
Type: text/x-patch
Size: 65863 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200225/6de04602/attachment.bin>