[PATCH] D73227: [ms] [llvm-ml] Use default RIP-relative addressing for x64 MASM.

Tue Feb 25 11:51:54 PST 2020

mstorsjo added a comment.

In D73227#1891931 <https://reviews.llvm.org/D73227#1891931>, @epastor wrote:

> It's true, MSVC doesn't support inline assembly at all on non-i386 platforms.
>
> However, LLVM currently does support MS-style inline assembly on x86-64, if you use the MS-style asm blocks... it just doesn't quite work as expected. (We've seen a few bug reports to this effect, including http://llvm.org/PR44272 - several of which have said the option of MS-style inline assembly on x86-64 is a big bonus.) Handling that here would move it closer to fully working.

Oh, ok - I see. In that case, keeping the gcc style inline assembly behaviour for `asm()` blocks and ms style for `__asm {}` probably is best - if it isn't a huge extra effort.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73227/new/

https://reviews.llvm.org/D73227