[PATCH] D73227: [ms] [llvm-ml] Use default RIP-relative addressing for x64 MASM.

Eric Astor via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 25 11:24:36 PST 2020


epastor added a comment.

In D73227#1891874 <https://reviews.llvm.org/D73227#1891874>, @thakis wrote:

> Yuck.


There's a reasonable debate that this reflects the x64 instruction set better, but yeah.

> What's the plan for 64-bit inline asm?

It should probably be the same, admittedly. To clarify: isParsingInlineAsm will only be true when parsing inline MS-style assembly? If so, I'll rename it to isParsingInlineMSAsm in this patch, and let the handling trigger off of both.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73227/new/

https://reviews.llvm.org/D73227





More information about the llvm-commits mailing list