[PATCH] D73741: [SCEV] SCEVExpander::isHighCostExpansionHelper(): cost-model polynomial recurrence

[Roman Lebedev via Phabricator via llvm-commits]

lebedev.ri marked 3 inline comments as done.
lebedev.ri added a comment.

In D73741#1890707 <https://reviews.llvm.org/D73741#1890707>, @mkazantsev wrote:

> LGTM


Thank you for the review.
Here i will also add a FIXME to investigate whether this is too pessimistic.



================
Comment at: llvm/lib/Analysis/ScalarEvolutionExpander.cpp:2259
+    int PolyDegree = NAry->getNumOperands() - 1;
+    assert(PolyDegree >= 1 && "Should be at least affine.");
+
----------------
mkazantsev wrote:
> Maybe also assert that the last operand is not zero (trailing zeros should be thrown away on SCEV creation).
Good idea.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73741/new/

https://reviews.llvm.org/D73741