[PATCH] D75123: [obj2yaml, yaml2obj] - Read and dump the "Content" key of the RawContentSection section as array.

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 25 09:21:01 PST 2020


MaskRay added a comment.

Just wanted to flag up a concern: `"feff"` -> `[ 0xFE, 0xFF ]` can make an opaque section content longer.

  ## Comment 1.
  0xfe, 0xfe,
  ## Comment 2.
  0xfe, 0xfe ]

Sometimes there may be a need to describe a little-endian 32-bit value, for example. Is the proposal to use `0x01, 0x00, 0x00, 0x00` for a little-endian 1?

~180 tests in `test/tools/llvm-{objcopy,xray,objdump,elfabi,ar,dwarfdump}` `test/Object` `test/DebugInfo` `lld/test/ELF` need an update, too. If we support both `"0001"` and `[ 0x00, 0x01 ]`, we don't have to update those tests.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75123/new/

https://reviews.llvm.org/D75123





More information about the llvm-commits mailing list