[PATCH] D74560: Introduce DWARFDataExtractor::getInitialLength

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 25 08:28:42 PST 2020


jhenderson accepted this revision.
jhenderson added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/unittests/DebugInfo/DWARF/DWARFDataExtractorTest.cpp:12
+#include "gtest/gtest.h"
+using namespace llvm;
+
----------------
Nit: blank line before the `using` please.


================
Comment at: llvm/unittests/DebugInfo/DWARF/DWARFDataExtractorTest.cpp:58
+
+  // Zeroes are not an error, but without the Error object is hard to tell them
+  // apart from a failed read.
----------------
is hard -> it is hard


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74560/new/

https://reviews.llvm.org/D74560





More information about the llvm-commits mailing list