[PATCH] D74824: [objdump] Fix disassembly for call/branch instructions for ELF binaries built with -ffunction-sections

Tue Feb 25 07:39:00 PST 2020

davidb added a comment.

In D74824#1891171 <https://reviews.llvm.org/D74824#1891171>, @jhenderson wrote:

> In D74824#1891127 <https://reviews.llvm.org/D74824#1891127>, @davidb wrote:
>
> > In D74824#1890859 <https://reviews.llvm.org/D74824#1890859>, @jhenderson wrote:
> >
> > > Looks like you've got changes related to D74823 <https://reviews.llvm.org/D74823> mixed in here?
> >
> >
> > Yes I put a note in the original description mentioning that this has been split to a separate change.
>
>
> It would be clearer if you made them as two separate diffs, with the one that needs to be second based on the first one, so that Phabricator only shows the differences related to this patch (in other words, each Phabricator review represents one git commit). You can also indicate the dependency by saying "Depends on DXXXXXX" in the patch description, and Phabricator will then link the two patches together.

Done. I'm aware that there is more required to do on this change, but I don't want to continue until we answer the question about handling undefined symbols, or symbols defined in different text sections... First impression is that current behaviour that matches GNU is preferable.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74824/new/

https://reviews.llvm.org/D74824