[PATCH] D74308: [Debuginfo][NFC] Unify error reporting routines inside DebugInfoDWARF.
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 25 05:47:06 PST 2020
jhenderson added a comment.
Looks good, but I'd pull the ErrorPolicy related changes into a separate patch.
================
Comment at: llvm/unittests/DebugInfo/DWARF/DWARFDebugInfoTest.cpp:2532
- // Case 1: error handler handles all errors. That allows
- // DWARFContext to parse whole file and find both two errors we know about.
+ // DWARFContext parses whole file and finds both two errors we know about.
int Errors = 0;
----------------
"both two errors we know about" -> "the two errors we expect"
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74308/new/
https://reviews.llvm.org/D74308
More information about the llvm-commits
mailing list