[PATCH] D75043: [DWARFDebugLine] Avoid dumping prologue members we did not parse
James Henderson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 25 05:37:19 PST 2020
jhenderson accepted this revision.
jhenderson added a comment.
LGTM, with one nit.
================
Comment at: llvm/test/tools/llvm-dwarfdump/X86/debug_line_invalid.test:72
# NONFATAL-NEXT: Line table prologue
+# NONFATAL: prologue_length: 0x00000013
# NONFATAL-NOT: include_directories
----------------
Super nit: here and elsewhere, add a single space after `NONFATAL:` so that it's lined up the same as the other checks in this file (where the colon lines up with the second 'o' in 'prologue').
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D75043/new/
https://reviews.llvm.org/D75043
More information about the llvm-commits
mailing list