[PATCH] D75036: [DebugInfo] Describe call site values for chains of expression producing instrs

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added a comment.

Thanks for this!



================
Comment at: llvm/test/DebugInfo/MIR/AArch64/dbgcall-site-expr-chain.mir:116
+# CHECK-NEXT: DW_AT_location (DW_OP_reg2 W2)
+# CHECK-NEXT: DW_AT_GNU_call_site_value (DW_OP_breg19 W19+700, DW_OP_plus_uconst 0x9, DW_OP_plus_uconst 0x50)
+
----------------
Have you tried debugging this with GDB/LLDB? I'm wondering if debuggers are missing the support for that.

These expressions seems valid to me, but I'm not sure even GCC generate call values with "combined" expressions so far.


================
Comment at: llvm/test/DebugInfo/MIR/AArch64/dbgcall-site-expr-entry-value.mir:31
+
+  attributes #0 = { nounwind "disable-tail-calls"="false" "frame-pointer"="non-leaf" }
+  attributes #2 = { nounwind readnone speculatable willreturn }
----------------
Can we delete these?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75036/new/

https://reviews.llvm.org/D75036