[PATCH] D73728: [SCEV] SCEVExpander::isHighCostExpansionHelper(): cost-model add/mul

Max Kazantsev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 24 21:23:27 PST 2020


mkazantsev accepted this revision.
mkazantsev added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: llvm/lib/Analysis/ScalarEvolutionExpander.cpp:2247
+        continue;
+      BudgetRemaining -= PairCost;
+    }
----------------
Just a suggestion, feel free to ignore: break if `BudgetRemaining` goes below zero in the loop to save time processing really huge SCEVs with many operands.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73728/new/

https://reviews.llvm.org/D73728





More information about the llvm-commits mailing list