[PATCH] D68065: Propeller: LLD Support for Basic Block Sections

[Sriraman Tallam via Phabricator via llvm-commits]

tmsriram added a comment.

In D68065#1890650 <https://reviews.llvm.org/D68065#1890650>, @MaskRay wrote:

> 40+ comments have not been addressed.


Since the patch was split many of the changes didn't apply as we separated the shrink instruction optimization into another.  We will address the comments you pointed.

Sorry, but I don't think this can be accepted as is. I am not catching up recent discussions but I believe there are still major concerns about the overall approach, whether code should be implemented in CodeGenPrepare.cpp, etc.

Could you be more specific as to what is the major concern?  Removing code from CodeGenPrepare.cpp is for the LLVM patch, not this one, and is not a major concern, we will be updating that patch removing all code from CodeGenPrepare.cpp.    We cannot land this patch without first getiing the LLVM patch approved anyways.

> Mark as "Request Changes" in fear of an accidental commit.




CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68065/new/

https://reviews.llvm.org/D68065