[PATCH] D68065: Propeller:  LLD Support for Basic Block Sections
    Rui Ueyama via Phabricator via llvm-commits 
    llvm-commits at lists.llvm.org
       
    Mon Feb 24 18:33:57 PST 2020
    
    
  
ruiu accepted this revision.
ruiu added a comment.
This revision is now accepted and ready to land.
LGTM
================
Comment at: lld/ELF/Arch/X86_64.cpp:177
+
+  uint64_t addrLoc = (is.getOutputSection())->addr + is.outSecOff + r.offset;
+  uint64_t targetOffset =
----------------
nit: remove extra parentheses
================
Comment at: lld/ELF/Arch/X86_64.cpp:181
+                                                      addrLoc, *r.sym, r.expr),
+                   (config->wordsize * 8));
+
----------------
nit: remove extra parentheses
CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D68065/new/
https://reviews.llvm.org/D68065
    
    
More information about the llvm-commits
mailing list