[PATCH] D74773: [LLD][Debuginfo] create DWARFContext only once for the same object file.

[Fangrui Song via Phabricator via llvm-commits]

MaskRay added a comment.

This changes looks fine, though I have a question about a regex use.



================
Comment at: lld/test/ELF/gdb-index-parse-fail.s:5
 
-# CHECK: error: {{.*}}:(.debug_info): invalid reference to or invalid content in .debug_str_offsets[.dwo]: insufficient space for 32 bit header prefix
+# CHECK: warning: {{.*}}:{{(\(\.debug_info\):)?}} invalid reference to or invalid content in .debug_str_offsets[.dwo]: insufficient space for 32 bit header prefix
 
----------------
Why did the debug_info regex become complex now?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74773/new/

https://reviews.llvm.org/D74773