[PATCH] D75028: Make __builtin_amdgcn_dispatch_ptr dereferenceable and align at 4

[Yaxun Liu via Phabricator via llvm-commits]

yaxunl marked an inline comment as done.
yaxunl added inline comments.


================
Comment at: llvm/include/llvm/IR/IntrinsicsAMDGPU.td:144
 def int_amdgcn_dispatch_ptr :
-  GCCBuiltin<"__builtin_amdgcn_dispatch_ptr">,
   Intrinsic<[LLVMQualPointerType<llvm_i8_ty, 4>], [],
----------------
arsenm wrote:
> I don't think you actually need to delete this. It should be fine to leave it
I tried. If I leave this, clang will use the standard handling of target builtin functions for __builtin_amdgcn_dispatch_ptr and will not reach EmitAMDGPUBuiltinExpr to handle __builtin_amdgcn_dispatch_ptr.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75028/new/

https://reviews.llvm.org/D75028