[PATCH] D74006: [MC][ELF] Make linked-to symbol name part of ELFSectionKey

Mon Feb 24 17:31:11 PST 2020

MaskRay added a comment.

In D74006#1890487 <https://reviews.llvm.org/D74006#1890487>, @efriedma wrote:

> It seems like there's some bad interaction between this, ARM exception handling, and asm parsing.  I'm seeing link errors like `error: EXIDX sections .ARM.exidx(10) and .ARM.exidx(4) both link to text section.text(2)` if I build with "-via-file-asm", and link with binutils ld.  Reverting this patch seems to fix the issue.
>
> You can produce an object file with multiple .ARM.exidx sections using something like `echo "void h();void f(){}void g(){}" | clang -x c - -o armeh.o -c -via-file-asm --target=arm-eabi`
>
> I suspect that ARMELFStreamer::SwitchToEHSection is somehow triggering this code, but I'm not sure I follow how this is supposed to work.  And I'm not sure why -via-file-asm is relevant.

It seems that .ARM.exidx  should be special cases. Will send a fix soon.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74006/new/

https://reviews.llvm.org/D74006