[PATCH] D74985: [LiveDebugValues] Encode a location in VarLoc IDs, NFC [2/3]
Adrian Prantl via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 24 16:36:42 PST 2020
aprantl accepted this revision.
aprantl added inline comments.
This revision is now accepted and ready to land.
================
Comment at: llvm/lib/CodeGen/LiveDebugValues.cpp:436
- using VarLocMap = UniqueVector<VarLoc>;
+ class VarLocMap {
+ UniqueVector<VarLoc> VarLocs;
----------------
vsk wrote:
> aprantl wrote:
> > If it's has methods, it gets a doxygen comment :-)
> Ouch, I accidentally squashed the change to add doxygen comments to VarLocMap into D74986. Is it all right if I land the change there? Splitting the commit apart is a pain.
Sure. Just FYI, you can use a mixture of `git reset HEAD~1` (un-commit changes) and `git add -p` (selectively add changes to commit) to move lines from one commit to another.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74985/new/
https://reviews.llvm.org/D74985
More information about the llvm-commits
mailing list