[PATCH] D75087: [ORC] Add LookupKind::TransitiveStatic for linker-resolved transitive dependencies

[Stefan Gränitz via Phabricator via llvm-commits]

sgraenitz added inline comments.


================
Comment at: llvm/include/llvm/ExecutionEngine/Orc/Core.h:89
 ///          representing static archives should not pull in new definitions).
-enum class LookupKind { Static, DLSym };
+enum class LookupKind { Static, DLSym, TransitiveStatic };
 
----------------
This would need a description in the comment. Not sure though, if it's the best way to achieve my goal in the first place.


================
Comment at: llvm/lib/ExecutionEngine/Orc/RTDyldObjectLinkingLayer.cpp:54
+    ES.lookup(LookupKind::TransitiveStatic, SearchOrder, InternedSymbols,
               SymbolState::Resolved, std::move(OnResolvedWithUnwrap),
               RegisterDependencies);
----------------
Alternatively, the generator could make the decision dependent on the required symbol state. However, currently this information isn't passed to the generators.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75087/new/

https://reviews.llvm.org/D75087