[PATCH] D74989: [LoopTerminology] Loop Simplify Form

Stefanos Baziotis via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 24 15:06:35 PST 2020


baziotis marked 2 inline comments as done.
baziotis added inline comments.


================
Comment at: llvm/docs/LoopTerminology.rst:152
+a LoopPass. This pass is implemented in
+`LoopInfo.h http://llvm.org/doxygen/LoopSimplify_8h_source.html`_.
+When it is successful, the loop has:
----------------
This is an external link. I don't know if this is ok.


================
Comment at: llvm/include/llvm/Transforms/Utils/LoopSimplify.h:11-12
 // simpler form, which makes subsequent analyses and transformations simpler and
-// more effective.
+// more effective. A summary of this pass is documented in
+// https://llvm.org/docs/LoopTerminology.html#loop-simplify-form
 //
----------------
Instead of putting a link, we could just put the info that this file is missing because it's little. It's the pass manager info and the implication that there's a single latch.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74989/new/

https://reviews.llvm.org/D74989





More information about the llvm-commits mailing list