[PATCH] D73998: [DA] renaming the -da-disable-delinearization-checks option

Bardia Mahjour via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 24 14:48:00 PST 2020


bmahjour added a comment.

In D73998#1890088 <https://reviews.llvm.org/D73998#1890088>, @Meinersbur wrote:

> In D73998#1890027 <https://reviews.llvm.org/D73998#1890027>, @bmahjour wrote:
>
> > I think A should be `float A[n*n+2*n]` for it to even be an in-bound access,
>
>
> Mmmh maybe, haven't thought too much about it beforehand. Let's see.
>
> The last element accessed is
>
>   i = 2*n-1
>   j = n-1
>
>
> which accesses element
>
>   A[(n-1)*n + (2*n-1)] = A[n*n-n + 2*n-1 = A[n*n + 1*n - 1]
>
>
> that is, the array needs to be at least `A[n*n + n]`.


My bad. You are right!

Regarding the suggested names: "-da-allow-unsafe-derived(-multidimensional)-subscripts", "-da-disable-derived(-multidimensional)-index-range-checks", and "-da-assume-nonoverlapping-of-heuristically-derived-multidimensional-array-structures". Is there anyone you prefer over the existing `-da-disable-delinearization-checks`? If not I can abandon this revision.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73998/new/

https://reviews.llvm.org/D73998





More information about the llvm-commits mailing list