[PATCH] D74927: [MC][ARM] make Thumb function also if type attribute is set

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 24 13:34:21 PST 2020


efriedma added a comment.

I did not realize implicit `.thumb_func` was a thing.

I'm worried we're going to fix this edge case, and introduce some other weird edge case.  I would prefer that we infer the marking based on whether the first instruction in the function is Thumb, as opposed to the state of the assembler when some label/directive is written.  And if first instruction isn't known to be ARM or Thumb, we should error.  (We can figure this out the same way we generate mapping symbols.)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74927/new/

https://reviews.llvm.org/D74927





More information about the llvm-commits mailing list