[PATCH] D74143: [MLIR] Adding attribute setters generation for table gen

[Lei Zhang via Phabricator via llvm-commits]

antiagainst added a comment.

In D74143#1884098 <https://reviews.llvm.org/D74143#1884098>, @mehdi_amini wrote:

> In D74143#1881674 <https://reviews.llvm.org/D74143#1881674>, @antiagainst wrote:
>
> > To truly allow dialect writers to dictate what naming style they want to use, the dialect writer need to control what naming convention is used to generate these attribute getter methods too.
>
>
> I suspect any attempt to provide such facility (switching naming convention) will hit the issue of mismatch with Traits and inherited properties: I think it will require a major change in our infrastructure to provide this.


I don't quite see the reason. FWIW, the current way is **also** a naming convension; it can also hit the issue of mismatch with traits and inherited properties. And once that happens, the writer has no way to avoid but to change the attribute name at the moment. Providing the ability to choose actually mitigates that...


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74143/new/

https://reviews.llvm.org/D74143