[PATCH] D74986: [LiveDebugValues] Encode register location within VarLoc IDs [3/3]

[Adrian Prantl via Phabricator via llvm-commits]

aprantl accepted this revision.
aprantl added a comment.
This revision is now accepted and ready to land.

Those numbers are really impressive.



================
Comment at: llvm/lib/CodeGen/LiveDebugValues.cpp:449
   class VarLocMap {
-    UniqueVector<VarLoc> VarLocs;
+    std::map<VarLoc, uint32_t> Var2Index;
+    SmallDenseMap<uint32_t, std::vector<VarLoc>> Loc2Vars;
----------------
Comment: Index into what? Or perhaps even typedef a LocIndex type?


================
Comment at: llvm/lib/CodeGen/LiveDebugValues.cpp:1516
+  NumInserted += Diff.count();
+  Changed |= !Diff.empty();
 
----------------
This also *looks* nicer :-)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74986/new/

https://reviews.llvm.org/D74986