[PATCH] D73462: [dwarf-5] Support DebugInfo for Defaulted parameters for C++ templates

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 24 08:49:20 PST 2020


aprantl added a comment.

LGTM



================
Comment at: llvm/unittests/IR/MetadataTest.cpp:2106
+  auto *N =
+      DITemplateValueParameter::get(Context, Tag, Name, Type, false, Value);
   EXPECT_EQ(Tag, N->getTag());
----------------
For consistency, let's assign "false" to `bool Defaulted = false` and use that instead of hardcoding "false" here


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73462/new/

https://reviews.llvm.org/D73462





More information about the llvm-commits mailing list