[PATCH] D74823: [XCOFF/objdump] Fix crash in objdump when trying to use -r with XCOFF binaries

Mon Feb 24 08:12:38 PST 2020

jasonliu added a comment.

I want to understand how this change would help you avoid crashes in D74824 <https://reviews.llvm.org/D74824>.
I think the crash is due to removal of "if (InlineRelocs)" in

  if (InlineRelocs)
    RelocMap = getRelocsMap(*Obj);

After this change, you would still call //getRelocsMap()// no matter //Relocations// set to false or not, which is still resulting in crash.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74823/new/

https://reviews.llvm.org/D74823