[PATCH] D69665: [llvm-ar] Fix llvm-ar response file reading on Windows

[Owen Reynolds via Phabricator via llvm-commits]

gbreynoo marked an inline comment as done.
gbreynoo added inline comments.


================
Comment at: llvm/tools/llvm-ar/llvm-ar.cpp:1165
+
+  for (SmallVector<const char *, 0>::iterator ArgIt = Argv.begin();
+       ArgIt != Argv.end(); ++ArgIt) {
----------------
MaskRay wrote:
> I think we may need some refactoring first. Let me check if the parsing logic can be simplified.
By moving to iterators my hope was this area would be easier to read, however it is still not ideal. Any suggestions for further refactoring would be appreciated.


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69665/new/

https://reviews.llvm.org/D69665