[PATCH] D74944: [LoopVectorize] Fix cost for calls to functions that have vector versions
Nemanja Ivanovic via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 24 07:44:55 PST 2020
nemanjai added a comment.
In D74944#1887086 <https://reviews.llvm.org/D74944#1887086>, @fpetrogalli wrote:
> Hi @nemanjai ,
>
> thank you for updating the code.
>
> Sorry for being picky, I think you should add another test. Your code need to work also for the `vector-function-avi-variant` attribute and not just for the `-vector-library=` option.
>
> Kind regards,
>
> Francesco
Will do. Note also that this will be the only such test case as far as I can tell, so we might want to add some more coverage there as well independent of this patch.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74944/new/
https://reviews.llvm.org/D74944
More information about the llvm-commits
mailing list