[PATCH] D69989: Assume ieee behavior without denormal-fp-math attribute

[Sanjay Patel via Phabricator via llvm-commits]

spatel added inline comments.


================
Comment at: clang/lib/CodeGen/CGCall.cpp:1754
                              CodeGenOpts.FPDenormalMode.str());
-    if (CodeGenOpts.FP32DenormalMode.isValid()) {
+    if (CodeGenOpts.FP32DenormalMode != CodeGenOpts.FPDenormalMode) {
       FuncAttrs.addAttribute(
----------------
I haven't followed the FP32 patches as closely as others, so I might have missed the reasoning here. 

As-is, we may need to explicitly say that FP32 is IEEE while everything is else is not (although I assume that would be a strange config). 

Do we have a test for that?
Is that better than making the FP32 attribute behave like the other FP attribute (assume IEEE unless otherwise specified)?


================
Comment at: clang/test/Driver/denormal-fp-math.c:11
 
-// TODO: ieee is the implied default, and the flag is not passed.
-// CHECK-IEEE: "-fdenormal-fp-math=ieee,ieee"
+// TODO: is the implied default, and the flag is not passed.
+// CHECK-IEEE-NOT: -fdenormal-fp-math=
----------------
Remove 'TODO', but restore 'ieee'?


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D69989/new/

https://reviews.llvm.org/D69989