[PATCH] D71845: [AIX][XCOFF] add test for raw text section content and test section header

David Tenty via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Mon Feb 24 07:17:37 PST 2020


daltenty accepted this revision.
daltenty added a comment.
This revision is now accepted and ready to land.

Minor nit, but otherwise LGTM



================
Comment at: llvm/test/CodeGen/PowerPC/aix-return55.ll:5
+; RUN: llvm-readobj -sections %t.o | FileCheck --check-prefix=CHECKSECT %s
 
+ at strA = private unnamed_addr constant [14 x i8] c"hello world!\0A\00", align 1
----------------
nit: We might want to add a `RUN: not` case for the 64-bit so we don't forget to add it in the future


================
Comment at: llvm/test/CodeGen/PowerPC/aix-return55.ll:20
+;CHECKOBJ-NEXT: 00000008 .rodata.str1.1:
+;CHECKOBJ-NEXT:       8: 68 65 6c 6c                   xori 5, 3, 27756
+;CHECKOBJ-NEXT:       c: 6f 20 77 6f                   xoris 0, 25, 30575
----------------
nit: Remove the disassembly column from the check lines for this and `.data`, since we are actually only interested in the raw data


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D71845/new/

https://reviews.llvm.org/D71845





More information about the llvm-commits mailing list