[PATCH] D75036: [DebugInfo] Describe call site values for chains of expression producing instrs

[Djordje Todorovic via Phabricator via llvm-commits]

djtodoro added a comment.

This makes sense to me.



================
Comment at: llvm/lib/CodeGen/AsmPrinter/DwarfDebug.cpp:649
+  /// debug expression.
+  auto finishCallSiteParams = [&](auto Val, const DIExpression *Expr,
+                                  ArrayRef<FwdRegParamInfo> DescribedParams) {
----------------
dstenb wrote:
> Perhaps this lambda and `addToWorklist` should be separate functions now that they have grown quite a bit?
Hmm, I think so.

And definitely, I don't like catching all data with `[&]` when using lambdas (in spite of the fact that probably I put that here :)), but if we are refactoring that into a function, it is not important.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D75036/new/

https://reviews.llvm.org/D75036