[PATCH] D74306: [MIR][ARM] MachineOperand comments to print condition code names instead of constants
Oliver Stannard (Linaro) via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Mon Feb 24 02:15:24 PST 2020
ostannard accepted this revision.
ostannard added a comment.
This revision is now accepted and ready to land.
LGTM with one really minor nit.
================
Comment at: llvm/lib/Target/ARM/ARMBaseInstrInfo.cpp:501
+ unsigned OpIdx) const {
+ // Only support immediates for now
+ if (Op.getType() != MachineOperand::MO_Immediate)
----------------
Comments should end with full stops.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74306/new/
https://reviews.llvm.org/D74306
More information about the llvm-commits
mailing list