[PATCH] D74954: Add a basic tiling pass for parallel loops

[Stephan Herhut via Phabricator via llvm-commits]

herhut accepted this revision.
herhut added a comment.

Thanks!

LGTM with comments addressed.



================
Comment at: mlir/lib/Dialect/LoopOps/Transforms/ParallelLoopTiling.cpp:39
+  auto zero = b.create<ConstantIndexOp>(op.getLoc(), 0);
+  SmallVector<Value, 2> tileSizeConstants;
+  for (size_t i = 0; i != op.upperBound().size(); ++i) {
----------------
mega-nit: `tileSizeConstants.reserve`


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74954/new/

https://reviews.llvm.org/D74954