[PATCH] D74792: [SimplifyLibCalls][IRBuilder] Accept any IRBuilder in SimplifyLibCalls

[Nikita Popov via Phabricator via llvm-commits]

nikic added a comment.

@uabelho As this patch changes worklist order, that can also have an impact on the optimization result. For your example, the strlen is folded to zext of load. If the zext is DCEd first, the load is also DCEd (before this patch) and you end up with an empty function. If the load is processed first, it will fold to unreachable instead (after this patch). D75008 <https://reviews.llvm.org/D75008> will change the order again to perform DCE first, in which case the previous behavior will be restored. Both outcomes are generally fine though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74792/new/

https://reviews.llvm.org/D74792