[PATCH] D73980: [lit] add multi-cfgd test suite discovery

Yuanfang Chen via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Feb 23 20:18:32 PST 2020


ychen added a comment.

In D73980#1888537 <https://reviews.llvm.org/D73980#1888537>, @delcypher wrote:

> @ychen I need convincing that this feature is actually needed. Today the problem of multiple configurations is solved at the CMake level in compiler-rt where we have CMake generate multiple config directories that point to the same source tree. Each config is generated differently depending on the use case. Why isn't that sufficient for the problem you are trying to solve.
>
> The description of this change is also very incomplete.


Hi @delcypher, thanks for chime in. This patch is a pre-requisite of D73981 <https://reviews.llvm.org/D73981>, to solve the problem/inconvenience of not being able to do `llvm-lit /path/to/compiler-rt/x.test`. I will update the description.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D73980/new/

https://reviews.llvm.org/D73980





More information about the llvm-commits mailing list