[PATCH] D74797: [mlir] [VectorOps] Framework for progressive lowering of vector.contract
Nicolas Vasilache via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Sun Feb 23 19:42:48 PST 2020
nicolasvasilache added a comment.
Thanks for adding this Aart!
Made a quick pass as I am catching up.
I am wondering whether the impl could be simplified or whether some of the complexity is a fundamental property of the problem at hand?
================
Comment at: mlir/lib/Dialect/VectorOps/VectorTransforms.cpp:880
+/// performance of generated code
class ContractionOpLowering : public OpRewritePattern<vector::ContractionOp> {
public:
----------------
andydavis1 wrote:
> As discussed in person, let's add a TODO to separate the transpose cases out into a separate vector transpose operation.
+1, thanks Andy!
================
Comment at: mlir/lib/Dialect/VectorOps/VectorTransforms.cpp:867
/// Progressive lowering of ConstractionOp.
+/// One:
----------------
typo `Contraction`
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D74797/new/
https://reviews.llvm.org/D74797
More information about the llvm-commits
mailing list