[PATCH] D75018: Fix nullptr access

[Vivek Pandya via Phabricator via llvm-commits]

vivekvpandya created this revision.
vivekvpandya added a reviewer: aditya_nandakumar.
Herald added a subscriber: hiraditya.
Herald added a project: LLVM.

[GloablISel]
Do not pass nullptr in MachineOptimizationRemark constructor, as MBB pointer is used in DiagnosticInfoMIROptimization constructor and that results in nullptr access.


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D75018

Files:
  llvm/lib/CodeGen/GlobalISel/InstructionSelect.cpp
  llvm/lib/CodeGen/GlobalISel/Legalizer.cpp


Index: llvm/lib/CodeGen/GlobalISel/Legalizer.cpp
===================================================================
--- llvm/lib/CodeGen/GlobalISel/Legalizer.cpp
+++ llvm/lib/CodeGen/GlobalISel/Legalizer.cpp
@@ -321,7 +321,7 @@
   if (MF.size() != NumBlocks) {
     MachineOptimizationRemarkMissed R("gisel-legalize", "GISelFailure",
                                       MF.getFunction().getSubprogram(),
-                                      /*MBB=*/nullptr);
+                                      &MF.front());
     R << "inserting blocks is not supported yet";
     reportGISelFailure(MF, TPC, MORE, R);
     return false;
Index: llvm/lib/CodeGen/GlobalISel/InstructionSelect.cpp
===================================================================
--- llvm/lib/CodeGen/GlobalISel/InstructionSelect.cpp
+++ llvm/lib/CodeGen/GlobalISel/InstructionSelect.cpp
@@ -216,7 +216,7 @@
   if (MF.size() != NumBlocks) {
     MachineOptimizationRemarkMissed R("gisel-select", "GISelFailure",
                                       MF.getFunction().getSubprogram(),
-                                      /*MBB=*/nullptr);
+                                      &MF.front());
     R << "inserting blocks is not supported yet";
     reportGISelFailure(MF, TPC, MORE, R);
     return false;


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D75018.246103.patch
Type: text/x-patch
Size: 1284 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20200223/dc9f3f7f/attachment.bin>