[PATCH] D74691: [Attributor] add some pattern to containsCycle

[Stefanos Baziotis via Phabricator via llvm-commits]

baziotis added a comment.

In D74691#1888202 <https://reviews.llvm.org/D74691#1888202>, @omarahmed wrote:

> [Attributor]Detect SCCs with unbounded cycles
>
> 1. Updating D74691 <https://reviews.llvm.org/D74691>: [Attributor] add some pattern to containsCycle #
> 2. Enter a brief description of the changes included in this update.
> 3. The first line is used as subject, next lines as comment. #
> 4. If you intended to create a new revision, use:
> 5. $ arc diff --create


You don't need this part anywhere.

> This patch implements containsUnboundedCycle which checks for unbounded cycle
>  which is either a loop that does not have a maximal trip count or any other
>  cycle.
> 
> It contains some fixes for willreturn tests and addition of bounded
>  and unbounded loop tests.

That commit message I think is very good. It's good if you put it in the summary as well.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D74691/new/

https://reviews.llvm.org/D74691